added calculator solution#286
Open
andrii-demchenko wants to merge 3 commits into
Open
Conversation
lavrivskyi
suggested changes
Sep 14, 2021
| return firstValue * secondValue; | ||
| } | ||
| case '/' : { | ||
| if (secondValue == 0) { |
There was a problem hiding this comment.
Division by zero is not always forbidden.
Comment on lines
+49
to
+51
| assertEquals(expectedFirstZero, actualFirstZero); | ||
| assertEquals(expectedSecondZero, actualSecondZero); | ||
| assertEquals(expectedBothZero, actualBothZero); |
There was a problem hiding this comment.
Not sure that we should use few assertions in one test.
Author
There was a problem hiding this comment.
As i can see multiple assertions are used in tests from previous homeworks, so I decided to use them too.
Comment on lines
+179
to
+183
| void multiplyTwoMinNumbers_Ok() { | ||
| actual = calculatorService.calculate(Double.MIN_VALUE, Double.MIN_VALUE, '-'); | ||
| expected = 0; | ||
| assertEquals(expected, actual); | ||
| } |
Author
There was a problem hiding this comment.
fixed, didn't notice it. Thank you.
Comment on lines
+248
to
+252
| void raiseNegativeNumberToNegativePower_Ok() { | ||
| actual = calculatorService.calculate(-4, -2, '^'); | ||
| expected = 0.0625; | ||
| assertEquals(expected, actual); | ||
| } |
There was a problem hiding this comment.
Maybe we should use delta in such cases?
Author
There was a problem hiding this comment.
Worked fine for me without delta, but added it anyway
Max-Pochepets
suggested changes
Sep 14, 2021
| return firstValue * secondValue; | ||
| } | ||
| case '/' : { | ||
| if (firstValue != 0.0d && secondValue == 0) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (firstValue != 0.0d && secondValue == 0) { | |
| if (firstValue != 0 && secondValue == 0) { |
| double actualBothZero = calculatorService.calculate(0, 0, '+'); | ||
| double expectedFirstZero = 5; | ||
| double expectedSecondZero = 50; | ||
| double expectedBothZero = 0; |
Contributor
There was a problem hiding this comment.
you have expected variable. you can reassign value after each assertion
| void additionWithZero_Ok() { | ||
| double actualFirstZero = calculatorService.calculate(0, 5, '+'); | ||
| double actualSecondZero = calculatorService.calculate(50, 0, '+'); | ||
| double actualBothZero = calculatorService.calculate(0, 0, '+'); |
| } | ||
|
|
||
| @Test | ||
| void addTwoPositiveNumbers_Ok() { |
Contributor
There was a problem hiding this comment.
what method co we test?
Comment on lines
+57
to
+59
| actual = calculatorService.calculate(0, 0, '+'); | ||
| expected = 55; | ||
| assertNotEquals(expected, actual); |
Contributor
There was a problem hiding this comment.
what is this test? how should it fail?
Comment on lines
+110
to
+115
| @Test | ||
| void subtractTwoZeroNumbers_NotOk() { | ||
| actual = calculatorService.calculate(0, 0, '-'); | ||
| expected = 5555; | ||
| assertNotEquals(expected, actual); | ||
| } |
| } | ||
|
|
||
| @Test | ||
| void raisingNegativeToZeroPower_Ok() { |
Contributor
There was a problem hiding this comment.
what about zeroToNegativePower?
Max-Pochepets
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.