Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/main/java/core/basesyntax/Application.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package core.basesyntax;

public class Application {
public static void main(String[] args) {
List<String> list = new ArrayList<>();
list.add("First");
list.add("Second");
list.add("Third");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this empty line. According to the checklist, there should be no empty lines between field declarations and constructor - the constructor should immediately follow the fields.

System.out.println("List size: " + list.size());
System.out.println("Element at index 1: " + list.get(1));
}

}
74 changes: 65 additions & 9 deletions src/main/java/core/basesyntax/ArrayList.java
Original file line number Diff line number Diff line change
@@ -1,48 +1,104 @@
package core.basesyntax;

import java.util.NoSuchElementException;

Comment on lines 2 to +4
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item #2 violation: Remove the empty line. Don't begin class implementation with an empty line - the class body starts immediately after the opening brace.

public class ArrayList<T> implements List<T> {
private static final int DEFAULT_CAPACITY = 10;
private T[] elements;
private int size;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item #2 violation: Remove the empty line. Don't begin the constructor body with an empty line - the implementation starts right after the opening brace.

public ArrayList() {
elements = (T[]) new Object[DEFAULT_CAPACITY];
}

@Override
public void add(T value) {

if (size == elements.length) {
grow();
}
elements[size++] = value;
}

@Override
public void add(T value, int index) {

if (index < 0 || index > size) {
throw new ArrayListIndexOutOfBoundsException("Index: " + index + ", Size: " + size);
}
if (size == elements.length) {
grow();
}
System.arraycopy(elements, index, elements, index + 1, size - index);
elements[index] = value;
size++;
}

@Override
public void addAll(List<T> list) {

for (int i = 0; i < list.size(); i++) {
add(list.get(i));
}
}

@Override
public T get(int index) {
return null;
checkIndex(index);
return elements[index];
}

@Override
public void set(T value, int index) {

checkIndex(index);
elements[index] = value;
}

@Override
public T remove(int index) {
return null;
checkIndex(index);
T removedElement = elements[index];
System.arraycopy(elements, index + 1, elements, index, size - index - 1);
size--;
return removedElement;
}

@Override
public T remove(T element) {
return null;
int index = -1;
for (int i = 0; i < size; i++) {
if (elements[i] == null && element == null
|| elements[i] != null && elements[i].equals(element)) {
index = i;
break;
}
}
if (index == -1) {
throw new NoSuchElementException("Element not found in the list");
}
return remove(index);
}

@Override
public int size() {
return 0;
return size;
}

@Override
public boolean isEmpty() {
return false;
return size == 0;
}

private void grow() {
int newCapacity = (int) (elements.length * 1.5);
if (newCapacity == elements.length) {
newCapacity++;
}
T[] newElements = (T[]) new Object[newCapacity];
System.arraycopy(elements, 0, newElements, 0, size);
elements = newElements;
}

private void checkIndex(int index) {
if (index < 0 || index >= size) {
throw new ArrayListIndexOutOfBoundsException("Index: " + index + ", Size: " + size);
}
}
}
Loading