-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Implement array list #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Implement array list #1789
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,48 +1,105 @@ | ||
| package core.basesyntax; | ||
|
|
||
| import java.util.NoSuchElementException; | ||
| import java.util.Objects; | ||
|
|
||
| public class ArrayList<T> implements List<T> { | ||
| private static final int INIT_CAPACITY = 10; | ||
| private Object[] elements = new Object[INIT_CAPACITY]; | ||
| private int size = 0; | ||
|
|
||
| @Override | ||
| public void add(T value) { | ||
|
|
||
| if (size == elements.length) { | ||
| increaseSize(); | ||
| } | ||
| elements[size++] = value; | ||
| } | ||
|
|
||
| @Override | ||
| public void add(T value, int index) { | ||
|
|
||
| checkIndexBounds(index); | ||
| if (size == elements.length) { | ||
| increaseSize(); | ||
| } | ||
| System.arraycopy(elements, 0, elements, 0, size - index); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CRITICAL BUG: This |
||
| System.arraycopy(elements, index, elements, index + 1, size - index); | ||
| elements[index] = value; | ||
| size++; | ||
| } | ||
|
|
||
| @Override | ||
| public void addAll(List<T> list) { | ||
|
|
||
| for (int i = 0; i < list.size(); i++) { | ||
| add(list.get(i)); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public T get(int index) { | ||
| return null; | ||
| checkIndexBoundsExcludingLastElement(index); | ||
| return (T) elements[index]; | ||
| } | ||
|
|
||
| @Override | ||
| public void set(T value, int index) { | ||
|
|
||
| checkIndexBoundsExcludingLastElement(index); | ||
| elements[index] = value; | ||
| } | ||
|
|
||
| @Override | ||
| public T remove(int index) { | ||
| return null; | ||
| checkIndexBoundsExcludingLastElement(index); | ||
| T element = get(index); | ||
| size--; | ||
| System.arraycopy(elements, index + 1, elements, index, size - index); | ||
| return element; | ||
| } | ||
|
|
||
| @Override | ||
| public T remove(T element) { | ||
| return null; | ||
| int index = indexOf(element); | ||
| if (index == -1) { | ||
| throw new NoSuchElementException("No such element"); | ||
| } | ||
| return remove(index); | ||
| } | ||
|
|
||
| @Override | ||
| public int size() { | ||
| return 0; | ||
| return size; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isEmpty() { | ||
| return false; | ||
| return size == 0; | ||
| } | ||
|
|
||
| private void increaseSize() { | ||
| Object[] newElements = new Object[size + (size >> 1)]; | ||
| System.arraycopy(elements, 0, newElements, 0, size); | ||
| elements = newElements; | ||
| } | ||
|
|
||
| private int indexOf(T element) { | ||
| for (int i = 0; i < size; i++) { | ||
| if (Objects.equals(element, elements[i])) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. CHECKLIST VIOLATION #2: |
||
| return i; | ||
| } | ||
| } | ||
| return -1; | ||
| } | ||
|
|
||
| private void checkIndexBounds(int index) { | ||
| if (index > size || index < 0) { | ||
| throw new ArrayListIndexOutOfBoundsException("Index: " + index + ", but size: " + size); | ||
| } | ||
| } | ||
|
|
||
| private void checkIndexBoundsExcludingLastElement(int index) { | ||
| if (index == size) { | ||
| throw new ArrayListIndexOutOfBoundsException("Index: " + index + ", but size: " + size); | ||
| } | ||
| checkIndexBounds(index); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHECKLIST VIOLATION #1: Empty line between field declarations and method implementation. Don't begin method implementation with an empty line.