Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 69 additions & 9 deletions src/main/java/core/basesyntax/ArrayList.java
Original file line number Diff line number Diff line change
@@ -1,48 +1,108 @@
package core.basesyntax;

import java.util.NoSuchElementException;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before class declaration violates checklist item #1: "Don't begin class or method implementation with an empty line."

public class ArrayList<T> implements List<T> {
private static final int DEFAULT_CAPACITY = 10;
private static final double GROW_FACTOR = 1.5;

private Object[] elementData;
private int size;

public ArrayList() {
elementData = new Object[DEFAULT_CAPACITY];
}

@Override
public void add(T value) {

growIfArrayFull();
elementData[size] = value;
size++;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before method implementation violates checklist item #1: "Don't begin class or method implementation with an empty line."

@Override
public void add(T value, int index) {

checkIndexForAdd(index);
growIfArrayFull();
System.arraycopy(elementData, index, elementData, index + 1, size - index);
elementData[index] = value;
size++;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before method implementation violates checklist item #1: "Don't begin class or method implementation with an empty line."

@Override
public void addAll(List<T> list) {

for (int i = 0; i < list.size(); i++) {
add(list.get(i));
}
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before method implementation violates checklist item #1: "Don't begin class or method implementation with an empty line."

@Override
@SuppressWarnings("unchecked")
public T get(int index) {
return null;
checkIndex(index);
return (T) elementData[index];
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before method implementation violates checklist item #1: "Don't begin class or method implementation with an empty line."

@Override
public void set(T value, int index) {

checkIndex(index);
elementData[index] = value;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before method implementation violates checklist item #1: "Don't begin class or method implementation with an empty line."

@Override
@SuppressWarnings("unchecked")
public T remove(int index) {
return null;
checkIndex(index);
T removedElement = (T) elementData[index];
System.arraycopy(elementData, index + 1, elementData, index, size - index - 1);
elementData[--size] = null;
return removedElement;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before method implementation violates checklist item #1: "Don't begin class or method implementation with an empty line."

@Override
public T remove(T element) {
return null;
for (int i = 0; i < size; i++) {
if (elementsAreEqual(elementData[i], element)) {
return remove(i);
}
}
throw new NoSuchElementException("Element not found: " + element);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before method implementation violates checklist item #1: "Don't begin class or method implementation with an empty line."

@Override
public int size() {
return 0;
return size;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before method implementation violates checklist item #1: "Don't begin class or method implementation with an empty line."

@Override
public boolean isEmpty() {
return false;
return size == 0;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before method implementation violates checklist item #1: "Don't begin class or method implementation with an empty line."

private void growIfArrayFull() {
if (size == elementData.length) {
int newCapacity = (int) (elementData.length * GROW_FACTOR);
Object[] grownArray = new Object[newCapacity];
System.arraycopy(elementData, 0, grownArray, 0, size);
elementData = grownArray;
}
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before method implementation violates checklist item #1: "Don't begin class or method implementation with an empty line."

private void checkIndex(int index) {
if (index < 0 || index >= size) {
throw new ArrayListIndexOutOfBoundsException(
"Index " + index + " is out of bounds for size " + size);
}
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before method implementation violates checklist item #1: "Don't begin class or method implementation with an empty line."

private void checkIndexForAdd(int index) {
if (index < 0 || index > size) {
throw new ArrayListIndexOutOfBoundsException(
"Index " + index + " is out of bounds for size " + size);
}
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line before method implementation violates checklist item #1: "Don't begin class or method implementation with an empty line."

private boolean elementsAreEqual(Object fromArray, T element) {
return fromArray == element || (fromArray != null && fromArray.equals(element));
}
}
Loading