Skip to content

init#1814

Open
nex1994 wants to merge 3 commits into
mate-academy:masterfrom
nex1994:develop
Open

init#1814
nex1994 wants to merge 3 commits into
mate-academy:masterfrom
nex1994:develop

Conversation

@nex1994
Copy link
Copy Markdown

@nex1994 nex1994 commented May 9, 2026

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your table generation logic is working correctly with all 6 columns and proper calculations. However, there is a critical violation of a core task requirement: the people data array is hardcoded directly in main.js instead of being imported from people.json. The task description explicitly states "In main.js, import the file people.json", which means you need to use an import statement to load the data. This is not a stylistic preference—it is a fundamental requirement that must be fulfilled. Additionally, the <your_account> placeholder in your GitHub workflow template remains unreplaced. Please import the data properly and update your workflow configuration before resubmitting.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Replace hardcoded people array with import from lib/people.json as required by the task.
Replace <your_account> placeholder with actual GitHub username in README.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your main.js implementation correctly handles all the core requirements—importing the JSON data, building the table with all 6 columns, calculating age and century properly, and mapping gender values. However, the build is currently failing due to a missing type="module" attribute on the script tag in src/index.html (line 26). The error from Parcel is clear: "Browser scripts cannot have imports or exports" because ES6 imports require the module type declaration. You need to update your index.html file: html <script src="scripts/main.js"></script> should become: html <script type="module" src="scripts/main.js"></script> Without this fix, the bundler cannot process your JavaScript file and the task cannot be completed. This is a critical blocker that must be addressed for the application to work correctly.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved. All core requirements are correctly implemented: the main.js properly imports the JSON data, creates table rows with all 6 columns (name, gender, born, died, age, century), calculates age and century using the correct formulas, and appends rows to the dashboard table. The index.html already has type="module" on line 26, resolving the previous blocker. One minor item to address: check that the README.md DEMO LINK section has <your_account> replaced with your actual GitHub username before final submission. Great work on getting this working correctly!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants