Solution_js_task_generate_table_DOM#1809
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution requires changes to pass the automated tests. The Cypress integration test is failing because the 'sex' (gender) column is not being rendered in the generated table. The test expects to find content like 'Male' in the table cells but it never appears. While the code review mentioned all 6 cells should be present, the automated test confirms the sex column data is missing from the actual rendered output. You need to ensure the sex property from each person object is being added as a <td> cell in each table row. Verify that your row generation code includes the sex field and that the people.json file contains valid sex values for each person.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation successfully meets all requirements. The code correctly creates table rows with all 6 columns (name, gender, born, died, age, century), and the previously missing gender column issue has been resolved. The age calculation (person.died - person.born) and century calculation (Math.ceil(person.died / 100)) are both accurate. All checklist items pass and no functionality issues were found.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.