Skip to content

add task solution#1808

Open
yana-longstocking wants to merge 1 commit into
mate-academy:masterfrom
yana-longstocking:develop
Open

add task solution#1808
yana-longstocking wants to merge 1 commit into
mate-academy:masterfrom
yana-longstocking:develop

Conversation

@yana-longstocking
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved. All core functional requirements are met: the code correctly creates table rows with all 6 required cells (name, gender, born, died, age, century), finds the .dashboard table using document.querySelector, and appends the rows properly. Age calculation (person.died - person.born) and century calculation (Math.ceil(person.died / 100)) are both implemented correctly. The console.log mentioned in the task description was guidance for debugging during development and is not required in the final submission. Your implementation is clean, functional, and complete.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/scripts/main.js
// eslint-disable-next-line no-console
console.log(people); // you can remove it
const dashboard = document.querySelector('.dashboard');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task description mentions using console.log to inspect the people array for debugging. Consider adding this to help with development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants