https://pavlo111.github.io/js_task_generate_table_DOM/#1806
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation has a critical issue that is causing the test to fail. The Cypress test expects the gender column to display 'Male' or 'Female', but your code is directly outputting the raw values from the sex property which are 'm' or 'f'. You need to map these values correctly - for example, when person.sex === 'm', insert 'Male' into the table cell, and when person.sex === 'f', insert 'Female'. This is the root cause of the test failure at cypress/integration/taskGenerateTableDom.spec.js:23:9 where it times out waiting to find 'Male' content. Once you fix this mapping, the test should pass.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. The implementation correctly meets all task requirements - the gender mapping has been fixed to display 'Male' and 'Female' instead of 'm' and 'f', all six table columns (name, gender, born, died, age, century) are properly generated with correct calculations, and rows are correctly appended to the table with class 'dashboard'. Only the main.js file was modified as required. The previous failing Cypress test should now pass with this fix.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.