Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
1. Replace `<your_account>` with your Github username in the link
- [DEMO LINK](https://<your_account>.github.io/js_task_fix_form_DOM/)
- [DEMO LINK](https://Roma-Yamshchikov.github.io/js_task_fix_form_DOM/)
2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/)
- Run `npm run test` command to test your code;
- Run `npm run test:only -- -n` to run fast test ignoring linter;
Expand Down
16 changes: 16 additions & 0 deletions src/scripts/main.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
'use strict';

// write code here
const input = [...document.querySelectorAll('input')];
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement specifies getting inputs FROM the form tag. Currently selecting all input elements on the page. Consider using document.querySelector('form').querySelectorAll('input') or document.querySelectorAll('form input').


input.forEach((item) => {
const label = document.createElement('label');

const namePlaceholder =
item.getAttribute('name')[0].toUpperCase() +
item.getAttribute('name').slice(1);

item.setAttribute('placeholder', namePlaceholder);

label.classList.add('field-label');
label.setAttribute('for', item.id);
label.textContent = item.getAttribute('name');
item.before(label);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 4 of the requirements states to 'Append label elements to the parent container of input'. Using item.before() inserts the label as a sibling before the input. Consider using item.parentElement.appendChild(label) instead to properly append to the parent container.

});
Loading