-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Develop #5239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Develop #5239
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,46 @@ | ||
| 'use strict'; | ||
|
|
||
| /** | ||
| * @param {Object} state | ||
| * @param {Object} clone | ||
| * @param {Object[]} actions | ||
| * | ||
| * @return {Object[]} | ||
| */ | ||
|
|
||
| function transformStateWithClones(state, actions) { | ||
| // write code here | ||
| const arrStates = []; | ||
| const clone = { ...state }; | ||
|
||
|
|
||
| for (const action of actions) { | ||
| switch (action.type) { | ||
| case 'addProperties': { | ||
| if (action.extraData && typeof action.extraData === 'object') { | ||
| Object.assign(clone, action.extraData); | ||
| } | ||
| break; | ||
| } | ||
|
|
||
| case 'removeProperties': { | ||
| if (Array.isArray(action.keysToRemove)) { | ||
| for (const key of action.keysToRemove) { | ||
| delete clone[key]; | ||
| } | ||
| } | ||
| break; | ||
| } | ||
|
|
||
| case 'clear': { | ||
| for (const key in clone) { | ||
| delete clone[key]; | ||
| } | ||
| break; | ||
| } | ||
| } | ||
|
Comment on lines
15
to
41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This violates checklist item #3: 'switch/case should always have default case for error handling.'. Your |
||
|
|
||
| arrStates.push({ ...clone }); | ||
| } | ||
|
|
||
| return arrStates; | ||
| } | ||
|
|
||
| module.exports = transformStateWithClones; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSDoc here describes a parameter named
clone, but the function's first parameter is actuallystate. Please make sure the documentation accurately matches the function signature.