Skip to content
Open

Develop #5239

Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.2",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
37 changes: 35 additions & 2 deletions src/transformStateWithClones.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,46 @@
'use strict';

/**
* @param {Object} state
* @param {Object} clone

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSDoc here describes a parameter named clone, but the function's first parameter is actually state. Please make sure the documentation accurately matches the function signature.

* @param {Object[]} actions
*
* @return {Object[]}
*/

function transformStateWithClones(state, actions) {
// write code here
const arrStates = [];
const clone = { ...state };

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #5: 'use proper names for object copy'. The checklist suggests using a more descriptive name like stateCopy instead of clone.


for (const action of actions) {
switch (action.type) {
case 'addProperties': {
if (action.extraData && typeof action.extraData === 'object') {
Object.assign(clone, action.extraData);
}
break;
}

case 'removeProperties': {
if (Array.isArray(action.keysToRemove)) {
for (const key of action.keysToRemove) {
delete clone[key];
}
}
break;
}

case 'clear': {
for (const key in clone) {
delete clone[key];
}
break;
}
}
Comment on lines 15 to 41

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #3: 'switch/case should always have default case for error handling.'. Your switch statement should include a default case to handle any unknown action types that might be passed in.


arrStates.push({ ...clone });
}

return arrStates;
}

module.exports = transformStateWithClones;