-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Solving task #5220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Solving task #5220
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,31 @@ | |
| * @return {Object[]} | ||
| */ | ||
| function transformStateWithClones(state, actions) { | ||
| // write code here | ||
| const history = []; | ||
| let currentState = { ...state }; | ||
|
|
||
| for (let i = 0; i < actions.length; i++) { | ||
| const action = actions[i]; | ||
|
|
||
| if (action.type === 'addProperties') { | ||
| currentState = { ...currentState, ...action.extraData }; | ||
| history.push({ ...currentState }); | ||
| } else if (action.type === 'removeProperties') { | ||
| const nextState = { ...currentState }; | ||
|
|
||
| for (const key of action.keysToRemove) { | ||
| delete nextState[key]; | ||
| } | ||
|
|
||
| currentState = nextState; | ||
| history.push({ ...currentState }); | ||
| } else if (action.type === 'clear') { | ||
| currentState = {}; | ||
| history.push({ ...currentState }); | ||
| } | ||
|
||
| } | ||
|
|
||
| return history; | ||
| } | ||
|
|
||
| module.exports = transformStateWithClones; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
history.push()call is repeated in every conditional branch (see also lines 27 and 30). This violates checklist item #4: 'If you perform same action in allswitchcases - do it just once afterwards.' To avoid repetition, this line should be moved outside and after the conditional logic, so it executes once at the end of each loop iteration.