Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
35 changes: 19 additions & 16 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
26 changes: 25 additions & 1 deletion src/transformStateWithClones.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,31 @@
* @return {Object[]}
*/
function transformStateWithClones(state, actions) {
// write code here
const history = [];
let currentState = { ...state };

for (let i = 0; i < actions.length; i++) {
const action = actions[i];

if (action.type === 'addProperties') {
currentState = { ...currentState, ...action.extraData };
history.push({ ...currentState });

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This history.push() call is repeated in every conditional branch (see also lines 27 and 30). This violates checklist item #4: 'If you perform same action in all switch cases - do it just once afterwards.' To avoid repetition, this line should be moved outside and after the conditional logic, so it executes once at the end of each loop iteration.

} else if (action.type === 'removeProperties') {
const nextState = { ...currentState };

for (const key of action.keysToRemove) {
delete nextState[key];
}

currentState = nextState;
history.push({ ...currentState });
} else if (action.type === 'clear') {
currentState = {};
history.push({ ...currentState });
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if/else if structure violates a key requirement. Checklist item #2 states: 'Use switch statement if you have limited amount of conditions.' A switch statement on action.type would be more appropriate here. Additionally, this would allow you to include a default case for handling unknown action types, as required by checklist item #3.

}

return history;
}

module.exports = transformStateWithClones;