Skip to content

solution #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YuliiaCat wants to merge 2 commits into
base: main
Choose a base branch
from
Open

solution #1079

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80e252c
solution
YuliiaCat Mar 13, 2026
0bea650
solution
YuliiaCat Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions src/splitInteger.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,27 @@
const splitInteger = require('./splitInteger');

test(`should split a number into equal parts
if a value is divisible by a numberOfParts`, () => {});
if a value is divisible by a numberOfParts`, () => {
const result = splitInteger(6, 2);

expect(result[0]).toEqual(result[1]);
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion is a bit weak because it only checks if the first two elements are equal, but it doesn't verify the total number of elements in the array. A more robust approach is to check the entire array's structure and content, for example: expect(result).toEqual([3, 3]);. This ensures the array has the correct length and values.

});

test(`should return a part equals to a value
when splitting into 1 part`, () => {});
when splitting into 1 part`, () => {
const result = splitInteger(10, 1);

expect(result[0]).toEqual(10);
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion only checks the value of the first element. It doesn't guarantee that the array contains exactly one element as required. To make this test more precise, it's better to check the entire array. For instance: expect(result).toEqual([10]);.

});

test('should sort parts ascending if they are not equal', () => {
const result = splitInteger(5, 2);

expect(result).toEqual([2, 3]);
});

test('should sort parts ascending if they are not equal', () => {});
test('should add zeros if value < numberOfParts', () => {
const result = splitInteger(3, 5);

test('should add zeros if value < numberOfParts', () => {});
expect(result).toEqual([0, 0, 1, 1, 1]);
});
Loading