Added tests#1031
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Good work on creating this test suite. The tests are clear and cover several important scenarios. However, this requires a change because a required test case from the task description is missing. Please add a test to cover the example splitInteger(17, 4) to ensure full compliance with the requirements. Once that's added, this will be ready to go!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| test('should add zeros if value < numberOfParts', () => { | ||
| const actual = splitInteger(2, 3); | ||
| const expected = [0, 1, 1]; | ||
|
|
||
| expect(actual).toEqual(expected); | ||
| expect(actual).toContain(0); | ||
| }); |
There was a problem hiding this comment.
Your tests cover most of the examples from the requirements, but one is missing. Please review the task description and ensure all specified examples are tested.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this update! I'm happy to approve your solution. You've successfully addressed the feedback from the previous review by adding the missing test case. Your test suite is now comprehensive, covering all the examples from the task description and fully meeting the project's requirements. Great job getting this completed!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.