Skip to content

solution #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webEsperer wants to merge 3 commits into
base: main
Choose a base branch
from
Open

solution #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d8bd9d
solution
Oct 6, 2025
33d428c
fixed
Oct 6, 2025
538f279
solution
Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ module.exports = {
jest: true
},
rules: {
'no-proto': 0,
strict: 0,
'max-len': 0,
'no-proto': 'off'
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a brief comment explaining why the no-proto rule is disabled (for example, if some dependency or test utilities intentionally use __proto__). This helps future maintainers understand the rationale for turning the rule off.

Example (inline comment on this line):

// disable because tests use __proto__ for mocking legacy behavior
'no-proto': 'off'

No functional change required — this is a documentation suggestion to improve maintainability.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a brief inline comment explaining why no-proto is disabled. For example:

// Disabled because some tests use `__proto__` for legacy mocking
'no-proto': 'off'

This is a non-blocking clarity improvement so maintainers understand the rationale for the rule override.

},
plugins: ['jest']
};
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
Loading