Skip to content

js_split_integer #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shelyaa wants to merge 3 commits into
base: main
Choose a base branch
from
Open

js_split_integer #1018

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbceb5c
js_split_integer
shelyaa Sep 18, 2025
3c3bea7
task
shelyaa Oct 22, 2025
b49ea22
task
shelyaa Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ module.exports = {
jest: true
},
rules: {
'no-proto': 0,
strict: 0,
'max-len': 0,
'no-proto': 0
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule override disables no-proto using a numeric severity (0). This is valid, but for readability and explicitness prefer the string form. For example:

'no-proto': 'off'

Using 'off' makes the intent clearer to readers who may not remember numeric severities.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the previous review, it's more readable and conventional to use the string 'off' instead of the number 0 to disable an ESLint rule. While it works correctly, using the string makes the configuration easier to understand.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mentioned in the previous review. For better readability and consistency with ESLint standards, please use the string 'off' instead of the number 0 to disable this rule.

},
plugins: ['jest']
};
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
Loading