Skip to content

Solution#1540

Open
nyarachun wants to merge 1 commit into
mate-academy:masterfrom
nyarachun:develop
Open

Solution#1540
nyarachun wants to merge 1 commit into
mate-academy:masterfrom
nyarachun:develop

Conversation

@nyarachun
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

All core requirements are met: both promises are created with correct names and behavior (promise1 resolves on logo click, promise2 rejects after 3 seconds), and both success and error handlers are properly attached, appending the correct divs with appropriate classes and text. One minor improvement worth noting: your rejectHandler references data.message, but promise1 never rejects, making that code path dead code for that promise. While this doesn't break functionality, consider either using the resolved value consistently or adding a comment clarifying that the Error object pattern specifically applies to promise2. This is purely a code clarity note and not a blocker.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants