Skip to content

solution 1.0#1524

Open
Viktor-1995 wants to merge 1 commit into
mate-academy:masterfrom
Viktor-1995:develop
Open

solution 1.0#1524
Viktor-1995 wants to merge 1 commit into
mate-academy:masterfrom
Viktor-1995:develop

Conversation

@Viktor-1995
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation correctly meets all task requirements. Both promise1 and promise2 are properly created with the exact required behavior — promise1 resolves on .logo click, and promise2 rejects after 3 seconds. The success handler appends <div class="message">Promise was resolved!</div> and the error handler appends <div class="message error-message">Promise was rejected!</div> to the body as specified. All checklist items pass. A minor quality note: reject(errorShow) passes the function reference itself rather than a proper error value, which works but could be cleaner with reject() or reject(new Error(...)). This is not a blocker since the .catch() handler ignores the parameter. The unused e parameter in the click handler is a minor style issue. Overall, your solution is functionally complete and correct.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants