Skip to content

Develop#1520

Open
yuriisychovys-lang wants to merge 1 commit into
mate-academy:masterfrom
yuriisychovys-lang:develop
Open

Develop#1520
yuriisychovys-lang wants to merge 1 commit into
mate-academy:masterfrom
yuriisychovys-lang:develop

Conversation

@yuriisychovys-lang
Copy link
Copy Markdown

Replace https://github.com/yuriisychovys-lang with your Github username in the link
- DEMO LINK

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved because it correctly implements both promises, wires the .logo click to resolve the first promise, rejects the second promise after 3 seconds, and handles both success and error cases by appending the required <div> elements with the exact class names and text content to the document body. All core functional requirements of the task are met, and there are no critical issues that would block correct behavior or test execution. One improvement you should make outside the core logic is to update the demo link in your README/PR body (the line with https://<yuriisychovys-lang>.github.io/...) to your actual GitHub Pages URL so that reviewers and testers can access a working demo. In src/scripts/main.js, consider adding a small safety check around document.querySelector('.logo') or wrapping your promise setup in a DOMContentLoaded listener so the script won’t throw an error if the .logo element is missing or the script runs before the DOM is ready. It would also be good for consistency to keep comments in one language (for example, changing the "Podpinamy handlery" comment to English), although this is stylistic and not required for correctness. Overall, the implementation is concise, clear, and functionally solid—nice work on meeting the promise and DOM interaction requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants