-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add task solution v1 #1516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add task solution v1 #1516
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm start & sleep 5 && npm test | ||
| - name: Upload tests report(cypress mochaawesome merged HTML report) | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: report | ||
| path: reports |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,35 @@ | ||
| 'use strict'; | ||
|
|
||
| // write your code here | ||
| function showNotification(type, message) { | ||
| const notification = document.createElement('div'); | ||
|
|
||
| // eslint-disable-next-line max-len | ||
| notification.className = | ||
| 'message' + (type === 'error' ? ' error-message' : ''); | ||
| notification.textContent = message; | ||
| document.body.appendChild(notification); | ||
| } | ||
|
|
||
| const firstPromise = new Promise((resolve, reject) => { | ||
| const logo = document.querySelector('.logo'); | ||
|
|
||
| if (logo) { | ||
| logo.addEventListener('click', (eventy) => { | ||
| if (eventy.button === 0) { | ||
| resolve('Promise was resolved!'); | ||
| } | ||
| }); | ||
| } | ||
| }); | ||
|
|
||
| firstPromise | ||
| .then((message) => showNotification('success', message)) | ||
| .catch((err) => showNotification('error', err.message)); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This uses |
||
|
|
||
| const secondPromise = new Promise((resolve, reject) => { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The task requires a promise named |
||
| setTimeout(() => reject(new Error('Promise was rejected!')), 3000); | ||
| }); | ||
|
|
||
| secondPromise | ||
| .then((message) => showNotification('success', message)) | ||
| .catch((err) => showNotification('error', err.message)); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This block attaches handlers to |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The task requires creating a promise named
promise1, but here the promise is declared asfirstPromise. Rename this declaration toconst promise1 = new Promise(...)to match the requirement and update all references accordingly.