Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
1. Replace `<your_account>` with your Github username in the link
- [DEMO LINK](https://<your_account>.github.io/js_get_data_DOM/)
- [DEMO LINK](https://zubchenko-maksym.github.io/js_get_data_DOM/)
2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/)
- There are no tests for this task so use `npm run lint` command instead of `npm test`

Expand Down
16 changes: 15 additions & 1 deletion src/scripts/main.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
'use strict';

// write your code here
const population = document.querySelectorAll('.population');
const populationArray = [];

for (const el of population) {
populationArray.push(el.textContent.split(',').join(''));
}

const totalPopulationEl = document.querySelector('.total-population');
const averagePopulationEl = document.querySelector('.average-population');

const total = populationArray.reduce((acc, sum) => acc + Number(sum), 0);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires validating that string data can be converted to a number before conversion. Consider checking with isNaN() or !isNaN() before using Number(sum), or filter out invalid values before the reduce operation.

const average = Math.floor(total / populationArray.length);

totalPopulationEl.textContent = total.toLocaleString('en-US');
averagePopulationEl.textContent = average.toLocaleString('en-US');
2 changes: 1 addition & 1 deletion src/styles/_fonts.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@font-face {
font-family: Roboto, Arial, Helvetica, sans-serif;
src: url('../fonts/Roboto-Regular-webfont.woff') format('woff');
font-weight: normal;
font-style: normal;
src: url('../fonts/Roboto-Regular-webfont.woff') format('woff');
}
38 changes: 23 additions & 15 deletions src/styles/main.scss
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
@import 'fonts';

body {
background: #eee;
counter-reset: section;

display: flex;
margin: 0;
align-items: center;
justify-content: center;

width: 100vw;
height: 100vh;
justify-content: center;
align-items: center;
margin: 0;

font-family: Roboto, sans-serif;
counter-reset: section;

background: #eee;
}

h1 {
Expand All @@ -18,28 +22,32 @@ h1 {

.list {
margin: 32px 0;
list-style: none;
padding: 0;
list-style: none;
&__item {
margin: 8px;
border-bottom: 1px solid darkgrey;
position: relative;

display: flex;
justify-content: space-between;
padding: 4px 4px 4px 30px;
position: relative;

img {
margin-right: 8px;
}
margin: 8px;
padding: 4px 4px 4px 30px;
border-bottom: 1px solid darkgrey;

&::before {
color: #565754;
counter-increment: section;
content: counter(section);
counter-increment: section;

position: absolute;
top: 50%;
left: 5px;
transform: translateY(-60%);

color: #565754;
}

img {
margin-right: 8px;
}
}
}
Expand Down
Loading