-
Notifications
You must be signed in to change notification settings - Fork 2.1k
solution #2237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kit3AWP
wants to merge
2
commits into
mate-academy:master
Choose a base branch
from
Kit3AWP:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
solution #2237
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,23 @@ | ||
| 'use strict'; | ||
|
|
||
| // write your code here | ||
| const populationSpans = document.querySelectorAll('.population'); | ||
| const populationArray = Array.from(populationSpans); | ||
| const populationNumbers = populationArray.map((span) => { | ||
| const text = span.textContent; | ||
| const cleanText = text.replace(/[^\d]/g, ''); | ||
| const number = Number(cleanText); | ||
|
|
||
| return number; | ||
| }); | ||
|
|
||
| const total = populationNumbers.reduce((acc, num) => { | ||
| return acc + num; | ||
| }, 0); | ||
| const average = Math.round(total / populationNumbers.length); | ||
| const totalFormatted = total.toLocaleString(); | ||
| const averageFormatted = average.toLocaleString(); | ||
| const totalSpan = document.querySelector('.total-population'); | ||
| const averageSpan = document.querySelector('.average-population'); | ||
|
|
||
| totalSpan.textContent = totalFormatted; | ||
| averageSpan.textContent = averageFormatted; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The task requires the calculated numbers to have the 'same numeric style as populations presented'. The presented populations are whole numbers. When you calculate the average, it's likely to be a floating-point number (e.g.,
12345.67). UsingtoLocaleString()directly on this will result in a formatted string with decimals (e.g., "12,345.67"), which doesn't match the style of the other population figures.Consider rounding the average to the nearest whole number before formatting it.
Math.round()would be a good function to use for this.