Skip to content

Solution#1765

Open
Rostyslav452 wants to merge 1 commit into
mate-academy:masterfrom
Rostyslav452:develop
Open

Solution#1765
Rostyslav452 wants to merge 1 commit into
mate-academy:masterfrom
Rostyslav452:develop

Conversation

@Rostyslav452
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The gallery implementation correctly uses event delegation on the #thumbs container and the closest('a') method effectively handles both click scenarios—whether clicking directly on an img or on the a element itself. All task requirements are satisfied. One minor suggestion for robustness: consider adding a null check before accessing link.href, since closest('a') returns null if there's no a ancestor. While this won't occur with the current HTML structure, it's a good defensive practice: javascript const link = e.target.closest('a'); if (link) mainImage.src = link.href; Great work on implementing the core functionality correctly!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants