Skip to content

galery#1763

Open
MaksVash wants to merge 1 commit into
mate-academy:masterfrom
MaksVash:master
Open

galery#1763
MaksVash wants to merge 1 commit into
mate-academy:masterfrom
MaksVash:master

Conversation

@MaksVash
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation of src/scripts/main.js is correct and meets all functional requirements. The event delegation pattern is properly implemented with a single click listener on the #thumbs container, and closest('.list-item__link') successfully handles both cases when clicking directly on an img or on the parent a element. The gallery functionality works as expected with bilder.src = item.href updating the main image. The only note is that the README still contains the placeholder <your_account> in the demo link—this is a documentation issue rather than a code problem, so it doesn't block approval. Great work on the implementation!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants