-
Notifications
You must be signed in to change notification settings - Fork 1.7k
add task solution #1762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add task solution #1762
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm start & sleep 5 && npm test | ||
| - name: Upload tests report(cypress mochaawesome merged HTML report) | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: report | ||
| path: reports |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,20 @@ | ||
| 'use strict'; | ||
|
|
||
| const thumbsEl = document.querySelector('#thumbs'); | ||
| const largeImgEl = document.querySelector('#largeImg'); | ||
|
|
||
| thumbsEl.addEventListener('click', (ev) => { | ||
| ev.preventDefault(); | ||
|
|
||
| if (ev.target.tagName === 'A') { | ||
| largeImgEl.src = ev.target.href; | ||
| } | ||
|
|
||
| if (ev.target.tagName === 'IMG') { | ||
| largeImgEl.src = ev.target.parentElement.href; | ||
| } | ||
|
|
||
| if (ev.target.tagName === 'LI') { | ||
| largeImgEl.src = ev.target.querySelector('a').href; | ||
|
Comment on lines
+16
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The task requirements state that |
||
| } | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using
else ifinstead of separateifstatements. Since a click target can only be one element type at a time, using chainedelse ifis more efficient and prevents unnecessary condition checks.