-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Develop #1753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Develop #1753
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm start & sleep 5 && npm test | ||
| - name: Upload tests report(cypress mochaawesome merged HTML report) | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: report | ||
| path: reports |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,21 @@ | ||
| 'use strict'; | ||
| const thumbs = document.querySelector('#thumbs'); | ||
| const largeImg = document.querySelector('#largeImg'); | ||
|
|
||
| thumbs.addEventListener('click', (e) => { | ||
| e.preventDefault(); | ||
|
|
||
| const target = e.target; | ||
|
|
||
| let link; | ||
|
|
||
| if (target.classList.contains('gallery__thumb')) { | ||
| link = target.closest('a'); | ||
| } else if (target.classList.contains('list-item__link')) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same issue as line 11 - |
||
| link = target; | ||
| } else { | ||
| return; | ||
| } | ||
|
|
||
| largeImg.src = link.href; | ||
| largeImg.alt = link.title; | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The task specifies that
event.targetwill be animgoraelement. Instead of checking class names, consider checking the element's tag name:target.tagName === 'IMG'for images ortarget.tagName === 'A'for links. This matches the actual task requirements.