Skip to content

develop #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndrewT98 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

develop #1751

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8428be
develop
Apr 23, 2026
7ca2320
fix
Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,12 @@
'use strict';

const bigI = document.querySelector('#largeImg');
const small = document.querySelectorAll('.gallery__img');

small.forEach((img) => {
Comment on lines +4 to +6
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task requirement violation: You must use event delegation. Instead of adding listeners to each image individually, add ONE listener to a parent element (like the gallery container) and use event.target to detect which element was clicked.

img.addEventListener('click', () => {
if (bigI) {
bigI.src = img.src;
}
});
Comment on lines +6 to +11
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this loop-based approach with a single delegated event listener on a parent element. Use event.target to check if the click was on an img or a element, then update the main image accordingly.

});
Loading