version 1#1745
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because, although your JavaScript implementation of the gallery behavior is correct and meets the functional requirements, the pull request modifies files that were explicitly required to remain unchanged. The task states that only src/scripts/main.js should be edited, but your PR also changes README.md, package.json, package-lock.json, and .github/workflows/test.yml-template, which violates the submission rules and can cause automated checks to fail [CHECKLIST ITEM #3]. To resolve this, revert all changes in those extra files so that the only diff in your PR is in src/scripts/main.js. Functionally, your event delegation on #thumbs and handling of clicks on both the <img> and its surrounding <a> are solid, and you correctly update the large image’s src and alt. As a minor improvement (not required for acceptance), you could add a fallback when setting the large image’s alt, for example using an empty string if the thumbnail has no title, and consider using largeImg.alt = newAlt instead of setAttribute for clarity. Once the unrelated file changes are reverted, your solution should satisfy both the functional and checklist requirements, and you’re very close to a clean, fully compliant submission.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
No description provided.