Skip to content

firstSolution#2509

Open
NazariiKaban wants to merge 1 commit intomate-academy:masterfrom
NazariiKaban:develop
Open

firstSolution#2509
NazariiKaban wants to merge 1 commit intomate-academy:masterfrom
NazariiKaban:develop

Conversation

@NazariiKaban
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation successfully meets all requirements. The sort2 method is correctly added to Array.prototype without overriding the built-in sort, sorts arrays in place while returning the original reference, handles both default string comparison (lexicographic) and custom compare functions, and uses a custom bubble sort algorithm without invoking the built-in sort. All test criteria pass, including correct handling of lowercase/mixed-case strings and numeric comparisons using custom comparators. Great work implementing this according to the scaffold requirements inside applyCustomSort. The O(n²) complexity of bubble sort is acceptable for this task and not a blocker.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants