Skip to content

Solution #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s-slavets wants to merge 3 commits into
base: master
Choose a base branch
from
+20 −2
Open

Solution #2483

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84cc0b4
Solution
s-slavets Mar 16, 2026
4ffd8ea
Solution
s-slavets Mar 26, 2026
e9b31ba
Solution
s-slavets Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/arrayMethodSort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,21 @@
* Implement method Sort
*/
function applyCustomSort() {
[].__proto__.sort2 = function(compareFunction) {
// write code here
[].__proto__.sort2 = function (
compareFunction = (a, b) => String(a) > String(b),
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default compareFunction is not correctly implemented. It should return a number (negative, 0, or positive) to be compliant with the Array.prototype.sort specification, but it returns a boolean. For example, sorting [10, 1] will not work as expected because '10' > '1' evaluates to false. A correct implementation could use String.prototype.localeCompare or explicit checks to return -1, 0, or 1.

) {
for (let i = 0; i < this.length - 1; i++) {
for (let j = 0; j < this.length - 1; j++) {
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bubble sort implementation can be slightly optimized. After each full pass of the outer loop, the largest element for that pass is moved to its correct sorted position at the end of the unsorted portion of the array. Therefore, the inner loop doesn't need to check the elements that are already sorted. You can adjust the inner loop's condition to j < this.length - 1 - i.

if (compareFunction(this[j], this[j + 1]) > 0) {
const temp = this[j];

this[j] = this[j + 1];
this[j + 1] = temp;
}
}
}

return this;
};
}

Expand Down
Loading