Skip to content

completed the task #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SerhiyShimko wants to merge 3 commits into
base: master
Choose a base branch
from
Open

completed the task #2457

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
891bae2
completed the task
SerhiyShimko Jan 31, 2026
9a5207f
completed the task
SerhiyShimko Jan 31, 2026
27d17d0
completed the task
SerhiyShimko Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/arrayMethodSort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,24 @@
* Implement method Sort
*/
function applyCustomSort() {
[].__proto__.sort2 = function(compareFunction) {
// write code here
[].__proto__.sort2 = function (compareFunction) {
// const newArray = [];
let compair = compareFunction;
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a small typo in the variable name here. It should be compare instead of compair. This typo is used consistently throughout the function, so be sure to correct it in all places.


if (typeof compair !== 'function') {
compair = (a, b) =>
String(a) > String(b) ? 1 : String(a) < String(b) ? -1 : 0;
}

for (let i = 0; i < this.length - 1; i++) {
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation doesn't handle sparse arrays (arrays with empty slots) in the same way as the native Array.prototype.sort. The native method moves all empty slots to the end of the array, whereas your current logic treats them as undefined and includes them in the sorting comparison based on the string 'undefined'.

for (let j = i + 1; j < this.length; j++) {
if (compair(this[i], this[j]) > 0) {
[this[i], this[j]] = [this[j], this[i]];
}
}
}

return this;
};
}

Expand Down