Skip to content
Open

Develop #2456

Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
35 changes: 33 additions & 2 deletions src/arrayMethodSort.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,39 @@
* Implement method Sort
*/
function applyCustomSort() {
[].__proto__.sort2 = function(compareFunction) {
// write code here
[].__proto__.sort2 = function (compareFunction) {
const compare =
compareFunction ||
((a, b) => {
const sA = String(a);
const sB = String(b);

if (sA > sB) {
return 1;
}

if (sA < sB) {
return -1;
}

return 0;
});

let temp;

for (let i = 0; i < this.length; i++) {
for (let j = 0; j < this.length - 1; j++) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation of bubble sort is functional, but it can be made more efficient. After each pass of the outer loop (i), the largest element for that pass is moved to its correct final position at the end of the unsorted portion. Therefore, the inner loop doesn't need to iterate over the already-sorted elements. You can optimize this by reducing the upper bound of this loop with each outer loop iteration. Consider changing the condition to j < this.length - 1 - i.

const num = compare(this[j], this[j + 1]);

if (num > 0) {
temp = this[j];
this[j] = this[j + 1];
this[j + 1] = temp;
}
}
}

return this;
};
}

Expand Down