Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
39 changes: 37 additions & 2 deletions src/arrayMethodSort.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,43 @@
* Implement method Sort
*/
function applyCustomSort() {
[].__proto__.sort2 = function(compareFunction) {
// write code here
[].__proto__.sort2 = function (compareFunction) {
let sortFunction = compareFunction;
const records = this.map((item, i) => {
return { val: item, key: String(item), ind: i };
});
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this.map does not correctly handle sparse arrays (arrays with empty slots). When a sparse array is provided, your code will throw an error because map creates corresponding empty slots in the records array, and later access like records[j].key will fail on these empty slots.


const defaultComparator = (a, b) => {
if (a > b) {
return 1;
}

if (a < b) {
return -1;
}

return 0;
};

if (sortFunction === undefined) {
sortFunction = defaultComparator;
}

for (let i = 0; i < records.length; i++) {
for (let j = 0; j < records.length - 1 - i; j++) {
const result = sortFunction(records[j].key, records[j + 1].key);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom compareFunction should receive the original array elements to work correctly for different data types like numbers or objects. Currently, you are always passing the stringified key property, which does not match the behavior of the native sort method and will lead to incorrect results when a comparator is provided.


if (result > 0) {
[records[j], records[j + 1]] = [records[j + 1], records[j]];
}
}
}
Comment on lines +28 to +44
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sorting logic doesn't correctly handle sparse arrays (e.g., [1, , 3]). The native sort method should move empty slots to the end of the array without passing their undefined value to the compareFunction.

Your current implementation will pass undefined to the comparator, which can lead to incorrect results, especially with a numeric comparison function (e.g., (a, b) => a - b would result in NaN).

Please update the loop to detect and correctly handle these empty slots.


for (let i = 0; i < records.length; i++) {
this[i] = records[i].val;
}

return this;
};
}

Expand Down