-
Notifications
You must be signed in to change notification settings - Fork 2.7k
task solved #2453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
task solved #2453
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,8 +4,43 @@ | |
| * Implement method Sort | ||
| */ | ||
| function applyCustomSort() { | ||
| [].__proto__.sort2 = function(compareFunction) { | ||
| // write code here | ||
| [].__proto__.sort2 = function (compareFunction) { | ||
| let sortFunction = compareFunction; | ||
| const records = this.map((item, i) => { | ||
| return { val: item, key: String(item), ind: i }; | ||
| }); | ||
|
|
||
| const defaultComparator = (a, b) => { | ||
| if (a > b) { | ||
| return 1; | ||
| } | ||
|
|
||
| if (a < b) { | ||
| return -1; | ||
| } | ||
|
|
||
| return 0; | ||
| }; | ||
|
|
||
| if (sortFunction === undefined) { | ||
| sortFunction = defaultComparator; | ||
| } | ||
|
|
||
| for (let i = 0; i < records.length; i++) { | ||
| for (let j = 0; j < records.length - 1 - i; j++) { | ||
| const result = sortFunction(records[j].key, records[j + 1].key); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The custom |
||
|
|
||
| if (result > 0) { | ||
| [records[j], records[j + 1]] = [records[j + 1], records[j]]; | ||
| } | ||
| } | ||
| } | ||
|
Comment on lines
+28
to
+44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This sorting logic doesn't correctly handle sparse arrays (e.g., Your current implementation will pass Please update the loop to detect and correctly handle these empty slots. |
||
|
|
||
| for (let i = 0; i < records.length; i++) { | ||
| this[i] = records[i].val; | ||
| } | ||
|
|
||
| return this; | ||
| }; | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
this.mapdoes not correctly handle sparse arrays (arrays with empty slots). When a sparse array is provided, your code will throw an error becausemapcreates corresponding empty slots in therecordsarray, and later access likerecords[j].keywill fail on these empty slots.