Skip to content

implement sort #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GorleRajeshBharadwaj wants to merge 11 commits into
base: master
Choose a base branch
from
Open

implement sort #2446

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b803e87
Update arrayMethodSort.js
GorleRajeshBharadwaj Jan 18, 2026
9c42e2d
Update arrayMethodSort.js
GorleRajeshBharadwaj Jan 18, 2026
e6fb849
Update arrayMethodSort.js
GorleRajeshBharadwaj Jan 18, 2026
151d9b9
Update arrayMethodSort.js
GorleRajeshBharadwaj Jan 18, 2026
4e1751c
Update arrayMethodSort.js
GorleRajeshBharadwaj Jan 18, 2026
1def36f
Update arrayMethodSort.js
GorleRajeshBharadwaj Jan 18, 2026
00c6134
Update arrayMethodSort.js
GorleRajeshBharadwaj Jan 18, 2026
818e892
Update arrayMethodSort.js
GorleRajeshBharadwaj Jan 18, 2026
4443457
Update arrayMethodSort.js
GorleRajeshBharadwaj Jan 18, 2026
b08af47
Update arrayMethodSort.js
GorleRajeshBharadwaj Jan 18, 2026
95cf38a
Update arrayMethodSort.js
GorleRajeshBharadwaj Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/arrayMethodSort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,22 @@
function applyCustomSort() {
[].__proto__.sort2 = function(compareFunction) {
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The native Array.prototype.sort method has a default behavior for when no compareFunction is provided (it converts elements to strings and compares them). Your implementation will throw an error if called without an argument. Consider adding a default comparator if compareFunction is undefined.

// write code here
for (let i = this.length; i > 1; i--) {
for(let j = 0; j < i; j++) {
if (compareFunction(this[j], this[i]) < 0) {
swap(this, i, j);
}
}
}
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sorting algorithm has a couple of logical issues that prevent it from working correctly:

  1. The outer loop starts with i = this.length, which will cause an error because this[this.length] is undefined. Array indices only go up to length - 1.
  2. The comparison logic is flawed. You are comparing each element this[j] against a single element this[i]. A common sorting algorithm like bubble sort works by comparing adjacent elements (e.g., this[j] and this[j + 1]) and swapping them if they are in the wrong order.


return this;
};
}

function swap(arr, firstElementIndex, secondElementIndex) {
const tempPlaceHolder = arr[firstElementIndex];
arr[firstElementIndex] = arr[secondElementIndex];
arr[secondElementIndex] = tempPlaceHolder;
}

module.exports = applyCustomSort;
Loading