Fix search to match notes containing the term#9
Open
VikLchv wants to merge 1 commit into
Open
Conversation
search is meant to return every note that contains the term, but matches() in lib/store.js compared with ===, so "milk" only matched a note whose text was exactly "milk" — missing "buy milk" and "milk the almonds". Switched the predicate to String.includes, which is what the two failing tests expect. All three tests now pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit 4 Lesson 2 — fix the shipped bug, then commit it cleanly.
The bug
searchshould return every note that contains the term, butmatches()inlib/store.jscompared with===, so "milk" only matched a note whose text was exactly "milk" — missing "buy milk" and "milk the almonds".The fix
One line: switched the predicate to
String.includes, which is what the two failing tests expect.Tests
Started red (2 of 3 failing, on purpose). After the fix, all 3 pass (
npm test).notes.mdrecords the quick "fix search" message I'd have dashed off vs. the fuller message, as the lesson asks.🤖 Generated with Claude Code