Fix search: match notes by substring, not exact text#7
Open
Sauvage666 wants to merge 1 commit into
Open
Conversation
The `matches` function in `lib/store.js` was using strict equality (`===`) to compare note text against the search term, so only notes whose full text was identical to the term were returned. Replaced with `String.includes()` so that `search` correctly finds every note that *contains* the term anywhere in its text. All three search tests now pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/store.js: la funciónmatchesusaba===(igualdad exacta) en vez deincludes(), por lo quesearchsolo devolvía notas cuyo texto fuera idéntico al términoTest plan
npm test— 3/3 tests pasan🤖 Generated with Claude Code