fix: match notes by substring in search#2
Open
mgsell-lab wants to merge 1 commit into
Open
Conversation
The `matches` function compared note text with strict equality, so `search` only returned notes whose text was exactly the term. Users expect search to find every note that contains the term. Switch the comparison to `String.includes`, making `search` match on substrings as documented. This turns the two failing `search` tests green; all three tests now pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
matchesfunction compared note text with strict equality, sosearchonly returned notes whose text was exactly the term. Users expect search to find every note that contains the term.Switch the comparison to
String.includes, makingsearchmatch on substrings as documented. This turns the two failingsearchtests green; all three tests now pass.