Skip to content

The solution #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dianahorban477-bot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

The solution #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5adee20
The solution
dianahorban477-bot May 7, 2026
bc79ad6
The solution
dianahorban477-bot May 7, 2026
b1f3776
The solution
dianahorban477-bot May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
ARG PYTHON_VERSION=3.9-slim
FROM python:${PYTHON_VERSION} AS builder
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The browser access URL is malformed - missing // after http:. Should be http://localhost:8080 instead of http:localhost:8080. This breaks the link and fails requirement #13 which requires working browser access instructions.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Malformed URL - missing // after http:. Change http//:localhost:8080 to http://localhost:8080 so the URL is valid and users can access the application in a browser (requirement #13).



ENV PYTHONDONTWRITEBYTECODE=1
ENV PYTHONUNBUFFERED=1

WORKDIR /app

Comment on lines +1 to +9
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing requirement: The INSTRUCTION.md file does not contain instructions on accessing the application via a browser, which is required by the task description (requirement #13). Add instructions like: Open http://localhost:8080 in your browser after the run command.

COPY requirements.txt .
RUN pip install --no-cache-dir --prefix=/install -r requirements.txt

FROM python:${PYTHON_VERSION}

ENV PYTHONUNBUFFERED=1

COPY --from=builder /install /usr/local
COPY . .

RUN python manage.py migrate

EXPOSE 8080
CMD ["python", "manage.py", "runserver", "0.0.0.0:8080"]
10 changes: 10 additions & 0 deletions INSTRUCTION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# ToDo App Docker Instructions
"Open http//:localhost:8080 in your browser"
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL is malformed. Change http//:localhost:8080 to http://localhost:8080 (the // should come after http:, not inside it). This is required by checklist item #13 for working browser access instructions.

## Docker Hub
Link to image: https://hub.docker.com/repository/docker/dianahorban/todoapp/general
## Build and Run
```bash
# Build image
docker build -t todoapp .
# Run container
docker run -d -p 8080:8080 todoapp
Comment on lines +1 to +10
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The INSTRUCTION.md is missing the required instruction for accessing the application via a browser. Per the task requirements, this file must contain instructions on accessing the application via a browser (e.g., http://localhost:8080 or http://0.0.0.0:8080).

Loading