Devops_todolist#289
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This submission requires changes before it can be approved. Two critical requirements from the task description are not met: 1. Missing multi-stage build architecture - The Dockerfile contains only a single FROM instruction, but the task explicitly requires both a "build stage and run stage." You need to restructure the Dockerfile with at least two stages: a builder stage (using FROM python:3.10-slim AS builder) that installs dependencies and compiles, followed by a runtime stage that copies only the necessary artifacts. This is a standard Docker optimization that reduces image size and improves security. 2. Missing 1.0.0 image tag - The build instruction in INSTRUCTION.md uses docker build -t todoapp . instead of the required docker build -t todoapp:1.0.0 .. The version tag is mandatory per the requirements. Additionally, consider adding Docker Hub push instructions with the proper tag to INSTRUCTION.md for completeness. The good news is that your ARG, ENV, migration, and CMD configurations are all correctly implemented. Once you add the multi-stage structure and the 1.0.0 tag, the submission should meet all requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| # ToDo App Docker | ||
|
|
There was a problem hiding this comment.
The Dockerfile only has ONE stage (one FROM instruction), but the requirements explicitly state it must contain both 'build stage and run stage'. You need a multi-stage build with at least two FROM instructions - one for building and one for running.
| https://hub.docker.com/r/shvdw/todoapp | ||
|
|
||
| ## Build image | ||
| docker build -t todoapp . |
There was a problem hiding this comment.
The build instruction is missing the required 1.0.0 tag. According to the requirements, the image should be tagged as todoapp:1.0.0. Change docker build -t todoapp . to docker build -t todoapp:1.0.0 .
No description provided.