Skip to content

add docker setup #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vikki2611 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add docker setup #280

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73f0e12
add docker setup
Vikki2611 Apr 9, 2026
15ade7e
fix dockerfile + update instructions
Vikki2611 Apr 9, 2026
5179551
fix dockerfile configurable python path
Vikki2611 Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
ARG PYTHON_VERSION=3.12

FROM python:${PYTHON_VERSION}-slim AS builder

WORKDIR /app

COPY requirements.txt .

RUN pip install -r requirements.txt

COPY . .

ENV PYTHONUNBUFFERED=1

RUN python manage.py migrate

# CMD ["python", "manage.py", "runserver", "0.0.0.0:8080"]

FROM python:${PYTHON_VERSION}-slim

WORKDIR /app

COPY requirements.txt .

RUN pip install -r requirements.txt
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These instructions reinstall all the Python dependencies. However, the dependencies were already installed in the builder stage (on line 9). The packages installed in the builder stage are not carried over to this final stage, which makes the first installation redundant and the build process inefficient.

A better approach in a multi-stage build is to install dependencies once in a builder stage and then copy them to the final stage along with your application code. This would make the build faster and the Dockerfile more optimized.


COPY --from=builder /app /app

ENV PYTHONUNBUFFERED=1

CMD ["python", "manage.py", "runserver", "0.0.0.0:8080"]













18 changes: 18 additions & 0 deletions INSTRUCTION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# ToDo App Docker Instructions

## Build image
docker build -t todoapp:1.0.0 .

## Run container
docker run -p 8080:8080 todoapp:1.0.0

## Tag image
docker tag todoapp:1.0.0 vikkinech/todoapp:1.0.0

## Push to Docker Hub
docker push vikkinech/todoapp:1.0.0

## Docker Hub repository
https://hub.docker.com/r/vikkinech/todoapp


Loading