-
Notifications
You must be signed in to change notification settings - Fork 304
add docker setup #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vikki2611
wants to merge
3
commits into
mate-academy:main
Choose a base branch
from
Vikki2611:develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add docker setup #280
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| ARG PYTHON_VERSION=3.12 | ||
|
|
||
| FROM python:${PYTHON_VERSION}-slim AS builder | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY requirements.txt . | ||
|
|
||
| RUN pip install -r requirements.txt | ||
|
|
||
| COPY . . | ||
|
|
||
| ENV PYTHONUNBUFFERED=1 | ||
|
|
||
| RUN python manage.py migrate | ||
|
|
||
| FROM python:${PYTHON_VERSION}-slim | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY --from=builder /app /app | ||
|
|
||
| COPY --from=builder /usr/local/lib/python3.12/site-packages /usr/local/lib/python3.12/site-packages | ||
|
|
||
| COPY --from=builder /usr/local/bin /usr/local/bin | ||
|
|
||
| ENV PYTHONUNBUFFERED=1 | ||
|
|
||
| CMD ["python", "manage.py", "runserver", "0.0.0.0:8080"] | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # ToDo App Docker Instructions | ||
|
|
||
| ## Build image | ||
| docker build -t todoapp:1.0.0 . | ||
|
|
||
| ## Run container | ||
| docker run -p 8080:8080 todoapp:1.0.0 | ||
|
|
||
| ## Tag image | ||
| docker tag todoapp:1.0.0 vikkinech/todoapp:1.0.0 | ||
|
|
||
| ## Push to Docker Hub | ||
| docker push vikkinech/todoapp:1.0.0 | ||
|
|
||
| ## Docker Hub repository | ||
| https://hub.docker.com/r/vikkinech/todoapp | ||
|
|
||
| ## Open in browser | ||
| After running the container, open http://localhost:8080 in your browser. | ||
|
|
||
|
|
||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line successfully copies the installed packages, which is a great improvement. However, the Python version
3.12is hardcoded in the path. This undermines the flexibility of usingARG PYTHON_VERSIONat the top of the file. If you try to build this Dockerfile with a different version (e.g.,--build-arg PYTHON_VERSION=3.11), this instruction will fail.