Skip to content

new branch#557

Open
SashaGlazko wants to merge 16 commits into
mate-academy:masterfrom
SashaGlazko:Develop
Open

new branch#557
SashaGlazko wants to merge 16 commits into
mate-academy:masterfrom
SashaGlazko:Develop

Conversation

@SashaGlazko
Copy link
Copy Markdown

Copy link
Copy Markdown

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, there are some issues to fix:

  1. On desktop there should be larger padding
Image 2. Page title font size on desktop is wrong, please have a look on mockup Image 3. Underline should be closer to text, please check mockup Image 4. Sections should have the same size. Image 5. This paragraph should have wrong font-family Image 6. Spacing in footer should be fixed. Please check mockup Image

@SashaGlazko SashaGlazko requested a review from vadiimvooo March 28, 2026 20:05
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, just last fixes

  1. it would be better if these links opened in a new tab
Image Image
  1. align these icons
Image

@SashaGlazko SashaGlazko requested a review from etojeDenys March 29, 2026 10:14
Copy link
Copy Markdown

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done. Just fix position of language select
Image

@SashaGlazko SashaGlazko requested a review from vadiimvooo March 29, 2026 18:15
Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, but you need to fix this selection:

Image

@SashaGlazko SashaGlazko requested a review from brespect March 30, 2026 14:31
Copy link
Copy Markdown

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

A few things to improve:

  1. These images should be in portrait mode according to design on desktop
Image Image

And here
Image
Image

  1. These images should have less width/height according to design
Image Image
  1. It's better to disable scrolling when menu is open
Image
  1. It's better to remove autofill styles
Image

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

disable page scrolling (see step 11 of the checklist)

Image

@SashaGlazko SashaGlazko requested a review from etojeDenys March 30, 2026 18:31
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants