Skip to content

add task solution#550

Open
s-slavets wants to merge 3 commits into
mate-academy:masterfrom
s-slavets:develop
Open

add task solution#550
s-slavets wants to merge 3 commits into
mate-academy:masterfrom
s-slavets:develop

Conversation

@s-slavets
Copy link
Copy Markdown

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, let`s fix next:

  1. Add submit to the button and make sure you allow only e-mail values
Знімок екрана 2025-12-29 о 12 22 01
  1. Remove horizontal scroll from your page
Знімок екрана 2025-12-29 о 12 22 13
  1. Something went wrong with side menu, looks like vertical scroll here, let`s remove it:
Знімок екрана 2025-12-29 о 12 22 41
  1. Add cursor pointer effect to all clickable elements

@s-slavets s-slavets requested a review from brespect December 29, 2025 17:53
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

  1. disable page scrolling when the menu is open
image
  1. this section should be the full height of the screen
image image
  1. that should be a link
image

@s-slavets s-slavets requested a review from etojeDenys December 30, 2025 14:24
Copy link
Copy Markdown

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants