Skip to content

created namu page#547

Open
MykolaFatkullin wants to merge 7 commits into
mate-academy:masterfrom
MykolaFatkullin:develop
Open

created namu page#547
MykolaFatkullin wants to merge 7 commits into
mate-academy:masterfrom
MykolaFatkullin:develop

Conversation

@MykolaFatkullin
Copy link
Copy Markdown

@MykolaFatkullin
Copy link
Copy Markdown
Author

I removed rule scss/no-global-function-names from srylelintrc.js as it requires to use map.get instead if map-get, but our sass version does not support map.get function. Locally it helped, but how to solve it here, I don't know

Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job you did!

  1. When aside menu is opened, I still have a possibility to click outside of opened menu.
    Would you mind to stretch your menu to 100vh height?
image

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, let`s check next:

  1. Position of right image is defferent from the mockup:
{8CD72BD8-21AB-4AC7-A013-07D307C08FCE}
  1. Add hover effect to all buttons

  2. Missed arrow icon here:

{36B0D57C-C547-49C6-86B1-DCCC4DA5970C}

@MykolaFatkullin
Copy link
Copy Markdown
Author

Good progress, let`s check next:

  1. Position of right image is defferent from the mockup:
{8CD72BD8-21AB-4AC7-A013-07D307C08FCE} 2. Add hover effect to all buttons 3. Missed arrow icon here: {36B0D57C-C547-49C6-86B1-DCCC4DA5970C}

I checked demo link and code, and looks like arrow is present and hover is present for all buttons. Image is fixed

Copy link
Copy Markdown

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants