Skip to content

Develop#541

Open
Taipan-4ik wants to merge 6 commits into
mate-academy:masterfrom
Taipan-4ik:develop
Open

Develop#541
Taipan-4ik wants to merge 6 commits into
mate-academy:masterfrom
Taipan-4ik:develop

Conversation

@Taipan-4ik
Copy link
Copy Markdown

Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. there should not be a space
image
  1. tt should be a link to the google maps address, and the same should be true for the footer
image
  1. these sections should be on the same line
image
  1. these links should open in a new tab
image

@Taipan-4ik
Copy link
Copy Markdown
Author

  1. there should not be a space
image 2. tt should be a link to the google maps address, and the same should be true for the footer image 3. these sections should be on the same line image 4. these links should open in a new tab image

Hello! Regarding the first remark, I don’t see any spaces in this place on my landing page.

@Taipan-4ik Taipan-4ik requested a review from etojeDenys October 6, 2025 08:20
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

  1. there are two different hover effects
image image
  1. on the demo link, the space exists
image

@Taipan-4ik
Copy link
Copy Markdown
Author

almost done

  1. there are two different hover effects

image image
2. on the demo link, the space exists

image

“To be honest, I don’t even understand why this gap might appear. At normal screen scale on desktop I don’t see anything, but when the scale is changed, the gap does appear. However, when changing the scale, various changes often occur on the landing page.”

@Taipan-4ik Taipan-4ik requested a review from etojeDenys October 6, 2025 09:16
Copy link
Copy Markdown

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

  1. Please add cursor: pointer to ALL clickable elements on the page:
image
  1. When I'm typing my email here and click a button, there should be only reset event, without scrolling whole page up. Check out the rule #15 from this instruction

  2. Is this gaps (microgaps, better say) are consistent with Figma design?

image

Copy link
Copy Markdown

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants