add task solution#538
Open
Vall-Re wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK.
Checklist for preparing a portfolio project
Tech review
[x] 1. Add favicon
[x] 2. Add a smooth scroll for the whole page (
scroll-behavior: smooth;)[x] 3. All interactive elements(links, buttons, pictures, icons) should have a hover effect and cursor pointer. User must intuitively understand that he can interact with them
[x] 4. Pictures in the blocks "Exhibitions", "Events", "News" should be animated and somehow move on hover or when scrolling down the page
[x] 5. Make sure when you click on logo there is no 404 error (Use
href="#"inanchor tag)[x] 6. When you try to send the form there is no 405 error and the form is automatically cleared after submit and is scrolled to the top of the page or the page is reloaded
[x] 7. The form shouldn’t submit empty
[x] 8. After autocomplete the form, change the default styles. Read more about changing autocomplete styles
HR review
[x] 1. To make it clear to the recruiter what exactly this landing page is, it is better to give the whole web page the title “NAMU”
[x] 2. A landing page is implemented strictly according to the design in Figma
[x] 3. Links in the header and footer menus should lead to the corresponding blocks of the landing page
[x] 4. The speed of animations is the same throughout the landing page (for example, increasing when hovering or moving blocks when scrolling)
[x] 5. Placeholders in the forms suggest what to enter, and if there is a validation of the form, then it is clear in what format to enter the phone number
[x] 6. Make sure everything looks neat on mobile and without horizontal scrolling
[x] 7. The buttons "buy a ticket" and "register" should lead to the block "Plan a visit to the museum"
[x] 8. Buttons in the footer of the menu should also be clickable and lead to blocks on the landing page.
[x] 9. All the social icons in the footer should be clickable and open the museum's social networks in a new tab