solution#714
Open
IgorYuzepchyk wants to merge 2 commits into
Open
Conversation
Denys-Kravchuk9988
suggested changes
May 9, 2026
Denys-Kravchuk9988
left a comment
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Good job!
Checked this link: https://igoryuzepchyk.github.io/Museum
A few things to improve:
- It's better to add
cursor: pointerfor all interactive elements on the page
- I would recommend to remove autofill styles
- Block contacts should be interactive. It means that phone numbers should open an alert to call, emails should open mailbox and address should open google maps
- It's better to disable scrolling when menu is open
- It seems that slider doesn't work on tablet
Author
|
Не знаю, що зі слайдером не так, в мене все працює, моживо я по іншому очікую. Він опціональний наскільки я знаю, якщо там дуже довго переробляти пропустіть будь-ласка |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK