solution#710
Open
Eksonurit wants to merge 2 commits intomate-academy:masterfrom
Open
Conversation
2pasha
suggested changes
Apr 29, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
hi!
in general looks not bad
take a look on comments below
P.S. here on GH it's better to ask for review already finished project, and for review like this it's better to write in fe_chat 💬
| <section class="header__content"> | ||
| <div class="header__content__inner mt-md-1"> | ||
| <img | ||
| src="src/icons/NA MU.svg" |
There was a problem hiding this comment.
in general it's better to use one approach for styling, because here i can see tailwind and external style files at the same time. And it's can be hard to maintain this project
| @include hover(color, $c-white); | ||
|
|
||
| @include respond-to(md) { | ||
| width: 90% !important; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Привіт! Зверстав хедер сторінки. Було б круто отримати критику коду, можливо якісь поради, підказки як реалізувати верстку краще