Develop#556
Open
mariiamad wants to merge 15 commits intomate-academy:masterfrom
Open
Conversation
2pasha
suggested changes
Apr 7, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
here are some improvements:
- add smooth scroll for you page
- as for me: it would be better to remove
box-shadowfrom hover effects here
- it's better to use the same color for placeholders
-
in form ⬆️ all fields should be required and form should not be submitted if email is not valid
-
disable scrolling when menu is opened
- it would be great if this slider will work
etojeDenys
suggested changes
Apr 9, 2026
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
- make sure that both placeholders are the same colour
- page scrolling is still here
make sure you deploy your changes
Author
|
I found the issue with the demo page. The code changes were pushed, but the demo was not updated correctly. I fixed the deploy/script path issue, and now the demo link shows the latest version correctly. |
Denys-Kravchuk9988
approved these changes
Apr 10, 2026
Denys-Kravchuk9988
left a comment
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Good job!
The last minor fix it's recommended to do:
- It's better to add
cursor: pointerby hover these links
The rest looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(https://mariiamad.github.io/Kickstarter/)