Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device setting #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Device setting #38

wants to merge 7 commits into from

Conversation

jmohr01
Copy link
Contributor

@jmohr01 jmohr01 commented Nov 30, 2020

Seperated out the resource metanetworks_device_setting

Repository owner locked and limited conversation to collaborators Dec 14, 2020
mataneine
mataneine requested changes Dec 14, 2020
View reviewed changes
Copy link
Owner

@mataneine mataneine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmohr01 Can you please rename it to device_settings instead of device_setting

@jmohr01 jmohr01 requested a review from mataneine August 18, 2021 01:22
Jamey Mohr added 2 commits August 18, 2021 11:47
added new settings options into resource, swg_always_on, ztna_always_…
32c45c8 
…on, block_lan_access, session_expired_action
changed option 'split_tunnel' to 'tunnel_type', bool -> string, expec…
7e43775 
…ted values split, full, as api has changed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mataneine mataneine Awaiting requested review from mataneine

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmohr01 @mataneine