fix: pin GitHub Actions to commit SHAs (INT-326)#21
Conversation
📝 WalkthroughWalkthroughThe PR updates GitHub Actions workflows and Trunk configuration to use newer versions. GitHub Actions references are pinned to newer commits: Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
oycyc
left a comment
There was a problem hiding this comment.
LGTM - GitHub Actions SHA pinning and tooling updates.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.trunk/trunk.yaml (1)
23-38: Please run one full Trunk pass before merge.Given the linter set/version changes, a
trunk checkandtrunk fmtrun is a good final validation step to catch any newly enforced rules.Based on learnings: Run Trunk for linting and formatting (trunk check, trunk fmt).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.trunk/trunk.yaml around lines 23 - 38, The Trunk toolset versions were changed in the YAML list (e.g., entries like taplo@0.10.0, black@26.3.1, ruff@0.15.9), so before merging run a full Trunk pass: execute `trunk check` to surface any new lint failures and `trunk fmt` to apply formatting changes, review and stage the resulting modifications (including any lock/metadata updates), and commit them so CI will pass with the updated linter/formatter rules.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.trunk/trunk.yaml:
- Around line 23-38: The Trunk toolset versions were changed in the YAML list
(e.g., entries like taplo@0.10.0, black@26.3.1, ruff@0.15.9), so before merging
run a full Trunk pass: execute `trunk check` to surface any new lint failures
and `trunk fmt` to apply formatting changes, review and stage the resulting
modifications (including any lock/metadata updates), and commit them so CI will
pass with the updated linter/formatter rules.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 89398851-a01b-4837-9493-0a4bd6fc212f
📒 Files selected for processing (6)
.github/workflows/lint.yaml.github/workflows/test.yaml.github/workflows/trunk-upgrade.yaml.trunk/configs/.isort.cfg.trunk/configs/ruff.toml.trunk/trunk.yaml
Info
uses:references in GitHub Actions workflows to full commit SHAs.References
Summary by CodeRabbit